Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert android format to sampled #86435

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

convert android format to sampled #86435

wants to merge 9 commits into from
+433 −63

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 5, 2025 •
edited
Loading

Lets just pretend like that format doesn't exist and convert it to sampled format

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 5, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9653 2 9651 10
View the top 2 failed test(s) by shortest run time 
ContinuousProfile android continuous profile chunk assigns stacks
Stack Traces | 0.004s run time 
TypeError: input is not iterable
    at eventedProfileToSampledProfile (.../profiling/profile/importProfile.tsx:181:25)
    at Object.<anonymous> (.../profiling/profile/continuousProfile.spec.tsx:165:73)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
ContinuousProfile android continuous profile chunk imports the base properties
Stack Traces | 0.011s run time 
TypeError: No timestamp found in metadata, typestamp is required to render continuous profiles
    at importAndroidContinuousProfileChunk (.../profiling/profile/importProfile.tsx:248:11)
    at Object.<anonymous> (.../profiling/profile/continuousProfile.spec.tsx:118:78)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@JonasBa JonasBa marked this pull request as ready for review March 6, 2025 13:57
@JonasBa JonasBa requested a review from a team as a code owner March 6, 2025 13:57
@JonasBa JonasBa requested review from viglia and stefanosiano March 6, 2025 13:57
@JonasBa JonasBa force-pushed the jb/profiling/android-flamecharts branch from 993b04b to 1d41728 Compare March 6, 2025 14:32
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 56.25kB (0.13%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 42.5MB 56.25kB (0.13%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_components_avatar_actorAvatar_tsx-app_components_avatar_avatarList_tsx-app_components_cha-7ec24d.*.js 3.83kB 1.4MB 0.27%
chunks/app_components_assigneeBadge_tsx-app_components_charts_components_markLine_tsx-app_components-38886d.*.js 120 bytes 1.16MB 0.01%
chunks/app_actionCreators_redirectToProject_tsx-app_actionCreators_sudoModal_tsx-app_components_aler-8bb7ac.*.js -1.38kB 456.27kB -0.3%
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx.*.js -8.19kB 360.43kB -2.22%
chunks/app_actionCreators_preferences_tsx-app_components_avatar_actorAvatar_tsx-app_components_confi-71c9ce.*.js 50 bytes 301.46kB 0.02%
chunks/app_components_events_eventEntries_tsx.*.js -14.35kB 233.8kB -5.78%
chunks/app_views_traces_content_tsx-node_modules_lodash_omitBy_js.*.js (New) 129.58kB 129.58kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-b11744.*.js 349 bytes 117.15kB 0.3%
entrypoints/app.js 19 bytes 108.53kB 0.02%
chunks/gsApp_views_decideCheckout_tsx.*.js 182 bytes 99.4kB 0.18%
chunks/app_components_profiling_flamegraph_flamegraphChart_tsx-app_components_profiling_flamegraph_f-767eed.*.js 41 bytes 92.55kB 0.04%
chunks/app_components_profiling_flamegraph_flamegraphTooltip_tsx-app_components_profiling_flamegraph-49a36e.*.js 2.82kB 89.4kB 3.26%
chunks/app_views_performance_transactionSummary_transactionSpans_spanDetails_index_tsx.*.js -1.55kB 69.94kB -2.17%
chunks/app_components_events_interfaces_spans_header_tsx-app_components_events_interfaces_spans_wate-4d4c7c.*.js 38 bytes 66.08kB 0.06%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f1e542.*.js (New) 54.77kB 54.77kB 100.0% 🚀
chunks/app_views_insights_pages_backend_backendOverviewPage_tsx-node_modules_lodash_partialRight_js.*.js 2.65kB 48.01kB 5.83% ⚠️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-f7da41.*.js 9.06kB 46.81kB 24.01% ⚠️
chunks/app_views_explore_charts_index_tsx-app_views_explore_hooks_useAnalytics_tsx-app_views_explore-e86025.*.js 162 bytes 45.38kB 0.36%
chunks/app_views_stories_index_tsx.*.js 1.52kB 45.21kB 3.47%
chunks/app_views_dashboards_contexts_widgetSyncContext_tsx-app_views_insights_browser_webVitals_view-ffe0ab.*.js -1.56kB 44.85kB -3.36%
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-5531f4.*.js 85 bytes 41.04kB 0.21%
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-62bd3d.*.js (New) 39.91kB 39.91kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-51a8df.*.js 85 bytes 37.62kB 0.23%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.8a1f42c6aaf93c445b83.js (New) 37.52kB 37.52kB 100.0% 🚀
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-91e88c.*.js (New) 36.47kB 36.47kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-b3f1e2.*.js 85 bytes 36.37kB 0.23%
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-4fd237.7b49759de50898f0b1a3.js (New) 35.73kB 35.73kB 100.0% 🚀
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-8653be.*.js (New) 34.98kB 34.98kB 100.0% 🚀
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_views_insights_common_components_-07f64e.*.js 85 bytes 34.63kB 0.25%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-dd1356.*.js (New) 32.82kB 32.82kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-a58c5e.*.js (New) 31.4kB 31.4kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.9adf698bede1ad628d57.js (New) 31.1kB 31.1kB 100.0% 🚀
chunks/app_views_dashboards_widgets_timeSeriesWidget_timeSeriesWidgetVisualization_tsx.*.js 12.15kB 28.53kB 74.13% ⚠️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-da34cb.*.js (New) 27.83kB 27.83kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.e1ac1a56d65b250a8310.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-4f9b0b.*.js 1.63kB 23.87kB 7.34% ⚠️
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_co-e286d9.*.js -1.46kB 19.13kB -7.1%
chunks/app_views_insights_database_views_databaseLandingPage_tsx.*.js -213 bytes 18.97kB -1.11%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-b49528.*.js (New) 18.13kB 18.13kB 100.0% 🚀
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-f70b67.*.js (New) 17.92kB 17.92kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.d7cf2b982ab81f6f7a7e.js (New) 17.41kB 17.41kB 100.0% 🚀
chunks/app_components_events_interfaces_llm-monitoring_llmMonitoringSection_tsx-node_modules_lodash_-e6ded3.*.js (New) 16.57kB 16.57kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.0224069adc6a7b2b138f.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_views_insights_common_components_tableCells_spanDescriptionCell_tsx.*.js (New) 15.7kB 15.7kB 100.0% 🚀
chunks/app_views_replays_deadRageClick_deadRageSelectorCards_tsx.*.js (New) 15.26kB 15.26kB 100.0% 🚀
chunks/app_components_events_interfaces_crashContent_exception_actionableItems_tsx-app_components_ev-206916.*.js (New) 15.03kB 15.03kB 100.0% 🚀
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-79f51f.*.js (New) 14.82kB 14.82kB 100.0% 🚀
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_components_profiling_profilingBre-60e72d.*.js 38 bytes 14.46kB 0.26%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.3012c89451764ac52524.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.3c283497bd437ee21655.js (New) 12.34kB 12.34kB 100.0% 🚀
chunks/app_components_charts_baseChart_tsx-app_components_charts_series_barSeries_tsx.*.js 206 bytes 11.31kB 1.86%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-4f3bc4.*.js 104 bytes 10.76kB 0.98%
chunks/app_components_replays_renderSortableHeaderCell_tsx-app_components_replays_useQueryBasedSorti-988c82.*.js (New) 10.44kB 10.44kB 100.0% 🚀
chunks/app_views_insights_mobile_screenload_components_screensView_tsx.*.js (New) 9.87kB 9.87kB 100.0% 🚀
chunks/vendors-node_modules_lodash_max_js-node_modules_lodash_min_js-node_modules_lodash_partialRigh-530812.*.js (New) 9.4kB 9.4kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f0.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f1.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f3.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f2.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f4.*.js 104 bytes 8.91kB 1.18%
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f6.*.js (New) 8.91kB 8.91kB 100.0% 🚀
chunks/vendors-node_modules_echarts_lib_component_dataZoomInside_js-node_modules_lodash_partialRight-e5351f5.*.js 104 bytes 8.91kB 1.18%
chunks/app_utils_replays_hooks_useDeadRageSelectors_tsx-app_views_replays_deadRageClick_selectorTable_tsx.*.js -1.19kB 8.8kB -11.91%
chunks/app_components_events_eventDrawer_tsx.*.js (New) 8.68kB 8.68kB 100.0% 🚀
chunks/app_views_traces_styles_tsx.*.js (New) 4.56kB 4.56kB 100.0% 🚀
chunks/app_views_traces_content_tsx-node_modules_lodash_omitBy_js-node_modules_lodash_partialRight_j-d4a98b.*.js (Deleted) -130.88kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-1e4e8f.*.js (Deleted) -57.54kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-a78653.*.js (Deleted) -39.44kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.938ff97b4f24906e3df4.js (Deleted) -37.52kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_areaChart_tsx-app_components_charts_series_scatterSeries_tsx-app_compon-4b7996.*.js (Deleted) -34.3kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_series_scatterSeries_tsx-app_components_feedback_widget_us*kWidg-2f9105.b8dff204991dfa341d53.js (Deleted) -34.19kB 0 bytes -100.0% 🗑️
chunks/app_utils_discover_discoverQuery_tsx-app_views_replays_list_tsx-node_modules_invariant_browser_js.*.js (Deleted) -32.01kB 0 bytes -100.0% 🗑️
chunks/app_views_performance_content_tsx-node_modules_echarts_lib_chart_scatter_js-node_modules_echa-b40361.*.js (Deleted) -31.38kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.7c10d1a51618189896ac.js (Deleted) -31.1kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-440387.*.js (Deleted) -26.97kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.2c90bfde639dd8340e81.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_views_dashboards_widgets_timeSeriesWidget_timeSeriesWidgetVisualization_stories_tsx.*.js (Deleted) -18.72kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.e1360f5ddbe5ee4ebfeb.js (Deleted) -17.41kB 0 bytes -100.0% 🗑️
chunks/app_components_gridEditable_sortLink_tsx-app_views_insights_common_components_tableCells_span-cdac7b.*.js (Deleted) -17.3kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_pages_mobile_mobileOverviewPage_tsx.*.js (Deleted) -16.64kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_pages_frontend_frontendOverviewPage_tsx.*.js (Deleted) -16.43kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.13326ffa25608bbd1db1.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_views_replays_deadRageClick_deadRageSelectorCards_tsx-app_utils_versions_semverCompare_ts.*.js (Deleted) -15.55kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.397ed9b0067f270cf8af.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_components_dataZoomInside_tsx-app_components_charts_components_toolBox_-01ad31.*.js (Deleted) -12.45kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.d3e82704e31a0d60ef0b.js (Deleted) -12.34kB 0 bytes -100.0% 🗑️
chunks/app_components_gridEditable_sortLink_tsx-app_views_insights_mobile_screenload_components_scre-1ff55c.*.js (Deleted) -11.5kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-1148da.*.js (Deleted) -10.53kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_common_components_moduleLayout_tsx-app_views_insights_llmMonitoring_compon-1886b3.*.js (Deleted) -9.82kB 0 bytes -100.0% 🗑️
chunks/app_utils_discover_discoverQuery_tsx-app_views_replays_deadRageClick_deadRageClickList_tsx.*.js (Deleted) -7.68kB 0 bytes -100.0% 🗑️
chunks/app_components_events_interfaces_llm-monitoring_llmMonitoringSection_tsx-app_views_insights_c-a549c5.*.js (Deleted) -7.44kB 0 bytes -100.0% 🗑️
chunks/app_views_traces_styles_tsx-node_modules_lodash_max_js-node_modules_lodash_min_js.*.js (Deleted) -5.17kB 0 bytes -100.0% 🗑️
chunks/app_views_dashboards_contexts_widgetSyncContext_stories_tsx.*.js (Deleted) -2.65kB 0 bytes -100.0% 🗑️

Files in chunks/app_components_assigneeBadge_tsx-app_components_charts_components_markLine_tsx-app_components-38886d.*.js:

  • ./app/utils/profiling/guards/profile.tsx → Total Size: 1.37kB

Files in chunks/app_components_profiling_flamegraph_flamegraphChart_tsx-app_components_profiling_flamegraph_f-767eed.*.js:

  • ./app/views/profiling/profilesProvider.tsx → Total Size: 5.25kB

Files in chunks/app_components_profiling_flamegraph_flamegraphTooltip_tsx-app_components_profiling_flamegraph-49a36e.*.js:

  • ./app/utils/profiling/profile/utils.tsx → Total Size: 9.87kB

Files in chunks/app_components_events_interfaces_spans_header_tsx-app_components_events_interfaces_spans_wate-4d4c7c.*.js:

  • ./app/views/profiling/profilesProvider.tsx → Total Size: 5.25kB

Files in chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_components_profiling_profilingBre-60e72d.*.js:

  • ./app/views/profiling/profilesProvider.tsx → Total Size: 5.25kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viglia viglia Awaiting requested review from viglia

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonasBa